fix: gateway requested with custom header requested from #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
f5eddbf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f0107709.nft-storage-1at.pages.dev |
alanshaw
reviewed
Feb 11, 2022
packages/gateway/src/gateway.js
Outdated
| @@ -236,6 +236,7 @@ function getHeaders(request) { | |||
| 'X-Forwarded-For': `${request.headers.get( | |||
| 'cf-connecting-ip' | |||
| )}${existingProxies}`, | |||
| 'X-Requested-From': 'nft.storage', | |||
There was a problem hiding this comment.
Perhaps we should use X-Forwarded-Host? WDYT?
There was a problem hiding this comment.
Yes, good call! I tried to find something like it, but my google early skills were not good 😅
vasco-santos
commented
Feb 11, 2022
vasco-santos
deleted the
fix/gateway-request-with-custom-header-requested-from
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using request headers host as value for the header per